Skip to content

Update nuspec to place library under netnano1.0 TFM#163

Merged
josesimoes merged 2 commits into
developfrom
copilot/update-nuspec-for-netnano
Mar 11, 2026
Merged

Update nuspec to place library under netnano1.0 TFM#163
josesimoes merged 2 commits into
developfrom
copilot/update-nuspec-for-netnano

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Mar 11, 2026

The nuspec was placing assembly files directly under lib\ with no target framework, and the dependency lacked a framework group — both incorrect for nanoFramework packages.

Changes

  • Dependencies: Wrapped nanoFramework.CoreLibrary dependency in <group targetFramework=".NETnanoFramework1.0">
  • Files: Replaced five individual file entries (dll, pdb, pdbx, pe, xml) with a single wildcard entry targeting lib\netnano1.0
<!-- Before -->
<dependencies>
  <dependency id="nanoFramework.CoreLibrary" version="2.0.0-preview.35" />
</dependencies>
<files>
  <file src="...\nanoFramework.System.Collections.dll" target="lib\nanoFramework.System.Collections.dll" />
  <file src="...\nanoFramework.System.Collections.pdb" target="lib\nanoFramework.System.Collections.pdb" />
  <!-- ... 3 more explicit entries -->
</files>

<!-- After -->
<dependencies>
  <group targetFramework=".NETnanoFramework1.0">
    <dependency id="nanoFramework.CoreLibrary" version="2.0.0-preview.35" />
  </group>
</dependencies>
<files>
  <file src="nanoFramework.System.Collections\bin\Release\nanoFramework.System.Collections.*" target="lib\netnano1.0" />
</files>

Pattern follows the System.Device.Adc reference.

Original prompt

This section details on the original issue you should resolve

<issue_title>Update nuspec to place library under nano TFM</issue_title>
<issue_description>### Details about task
Most of the nuspec files are not using the correct location to place the files.
Files (DLL, PE, PDBX and XML for IntelliSense) should be placed under "lib\netnano1.0" (currently are being placed under "lib" only.
Also they should declare a dependency group for ".NETnanoFramework1.0" target framework.
At the same time those still naming the various file types should use a wildcard instead (e.g. "...\Release\mscorlib.*).
The correct pattern should be (take this nuspec as sample):
nanoframework/System.Device.Adc@aab7bca

Do not change anything else on the nuspec file.

Work from the DEVELOP branch.

Description

</issue_description>

Comments on the Issue (you are @copilot in this section)


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Co-authored-by: josesimoes <1881520+josesimoes@users.noreply.github.com>
@josesimoes josesimoes marked this pull request as ready for review March 11, 2026 14:59
Copilot AI changed the title [WIP] Update nuspec to place library under nano TFM Update nuspec to place library under netnano1.0 TFM Mar 11, 2026
@sonarqubecloud
Copy link
Copy Markdown

@josesimoes josesimoes merged commit 0da4910 into develop Mar 11, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants