feat: add PHP 8.5 support #323
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update hasAptVersion() to support PHP 8.5 (5.6 || <=7.4 || <= 8.5)
- Add PHP 8.5 fallback version (8.5.0) in convertInstallVersion()
- Add PHP 8.5 to README.md version list
- Update workflow.yml matrix to test PHP 8.5
- Add test case for hasAptVersion('8.5')
- Update CLAUDE.md to reflect PHP 8.5 support
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude <noreply@anthropic.com>
Update the bundled distribution file to include PHP 8.5 support in hasAptVersion() function. The previous commit updated src/installer.ts and lib/installer.js but did not rebuild the dist/index.js bundle. This fixes the issue where PHP 8.5 was being installed via phpenv instead of APT on Ubuntu. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
PHP 8.5 has opcache bundled in the core, so the separate
php8.5-opcache package doesn't exist in the repository.
This caused "Unable to locate package php8.5-opcache" error.
Changes:
- Modified apt-install-php-ubuntu.sh to only install php${version}-opcache
for versions < 8.5
- Added conditional check: if version < 8.5, install opcache separately
- For PHP 8.5+, opcache is already included in php-common/php-cli
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude <noreply@anthropic.com>
Added documentation about PHP 8.5+ bundling opcache in core and updated version support checklist to include checking for bundled extensions when adding new PHP versions. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes
hasAptVersion()range to<= 8.5convertInstallVersion()hasAptVersion('8.5')Test plan
npm run build)npm run test)Related issues
This PR adds support for the latest PHP 8.5 release.
🤖 Generated with Claude Code