feat: declare action runtime as node24#4
Merged
Conversation
The action.yml was still declaring 'using: node12', the oldest Node runtime GitHub ever supported. GitHub has been auto-shimming forward to node16 / node20 via ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION for years; the current runner (v2.333.1, per #3) surfaces the warning: Node.js 20 actions are deprecated. Actions will be forced to run with Node.js 24 by default starting June 2nd, 2026. Declaring node24 explicitly makes the runtime match what the runner already ships (externals/node24) and removes the deprecation warning from every consumer's CI page. Compatibility: - dist/index.js reviewed for Node-22+ removals (util.isArray, createCipher, etc.) — none present. - Two 'new Buffer(...)' occurrences: one inside a lodash docstring comment (not executed), one in tunnel-agent's proxy-auth path (we never pass proxyAuth). 'new Buffer' emits DEP0005 on node24 but still works; no runtime break. - Verified dist is reproducible: NODE_OPTIONS=--openssl-legacy-provider npm run package produces byte-identical dist/index.js. Consumers pinning this action by SHA (e.g. namecheap/terraform- provider-namecheap) will rotate to the new commit in a follow-up. Signed-off-by: yuriyryabikov <22548029+kurok@users.noreply.github.com>
This was referenced Apr 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
One-line change in
action.yml:using: node12→using: node24.Why
The action still declared the oldest Node runtime GitHub ever supported. GitHub has been auto-shimming
node12forward for years (throughACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION), and the current runner (v2.333.1, merged in #3) now surfaces this warning on every consumer's Actions page:Declaring
node24explicitly aligns the action with what the runner already bundles (externals/node24), silences the deprecation warning for every downstream consumer (screenshotted onnamecheap/terraform-provider-namecheaphere), and is the direction GitHub is forcing us anyway.Compatibility check on dist/index.js
Grep'd for Node-22+ removals across the bundle:
util.isArray,util.isBoolean,util.isDate, etc.createCipher/createDecipher(withoutiv)new Buffer(...)tunnel-agent's proxy-auth path that we never invoke. EmitsDEP0005but still works on node24Nothing blocks node24 execution.
Reproducibility
NODE_OPTIONS=--openssl-legacy-provider npm run packageproduces a byte-identicaldist/index.js. Theverify-distCI job (added in #3) will confirm on this PR.Downstream follow-up
After this merges,
namecheap/terraform-provider-namecheapneeds a SHA-pin rotation (twouses:lines inci.yml). Same pattern as machulav#158 → provider machulav#159.