Stabilize HDoujin runtime: fix tag leak, harden staging, add helpers#8
Open
nacl-dev wants to merge 1 commit into
Open
Stabilize HDoujin runtime: fix tag leak, harden staging, add helpers#8nacl-dev wants to merge 1 commit into
nacl-dev wants to merge 1 commit into
Conversation
- Fix function:0x tag leak by skipping *lua.LFunction values in tableStrings(), infoString(), and luaValueToGo() conversions - Harden scanner to skip .tanuki-job-* staging dirs and .part files - Add lightweight test fixtures for large-gallery and chapter-series hosts - Add runtime helpers: Fail, SetParameter, DecodeBase64, StripParameters, Paginator.New - Update docs to reflect completed stabilization work Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
function:0xtag leak (P1): Collection/table-to-string-slice conversion now skips*lua.LFunctionvalues intableStrings(),infoString(), andluaValueToGo(), preventing helper methods from leaking into tags and metadata strings..tanuki-job-*staging directories and.partfiles during walks, so in-progress downloads never appear as library media.TestHDoujinLuaEngineLargeGalleryFixture(5-page gallery) andTestHDoujinLuaEngineChapterSeriesFixture(3-chapter series with JSON pages) replace the need for large live-site test runs during routine validation.Fail,SetParameter,DecodeBase64,StripParameters, andPaginator.Neware now registered in the Lua runtime, each with a dedicated test.docs/TODO_METADATA_AND_DOWNLOADS.mdanddocs/HDOUJIN_INTEGRATION_PLAN.mdupdated to reflect completed stabilization work.Test plan
go test ./internal/downloader/...passes (44 tests, including 9 new tests)function:0xstrings no longer appear in tag lists from Lua modules with collection helpers.tanuki-job-*directories and.partfiles during library scansFail(),SetParameter(),DecodeBase64(),StripParameters(), andPaginator.New()🤖 Generated with Claude Code