Skip to content

Conversation

@Lurkerpas
Copy link
Contributor

No description provided.

@Lurkerpas Lurkerpas requested review from Ficzer and Copilot and removed request for Ficzer December 8, 2025 15:26
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds support for parsing TASTE Deployment View (DV) XML files by introducing a new data model and XML reader implementation. The changes enable the template processor to work with deployment configurations that define how TASTE system components are deployed to physical/virtual hardware platforms.

  • Introduces DeploymentView data model with classes for nodes, partitions, functions, devices, connections, and messages
  • Implements DVReader for parsing deployment view XML files into the data model
  • Adds comprehensive test coverage with 13 test cases covering all aspects of the parser

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
templateprocessor/dv.py Defines data model classes for deployment view elements (nodes, partitions, devices, connections, messages)
templateprocessor/dvreader.py Implements XML parser that constructs DeploymentView objects from XML files or strings
tests/test_dvreader.py Comprehensive test suite covering all parsing scenarios including nodes, partitions, devices, connections, messages, and error handling
data/deploymentview.dv.xml Test data file containing sample deployment view XML with two nodes, partitions, devices, and a connection
tests/Makefile Updated to include the new test file in the test suite
Comments suppressed due to low confidence (1)

templateprocessor/dv.py:10

  • Import of 'Optional' is not used.
from typing import List, Optional

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Lurkerpas and others added 2 commits December 8, 2025 16:41
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@Lurkerpas Lurkerpas merged commit e3e9b85 into main Dec 9, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants