refactor(tests): Remove TestEndpoint::addr#666
Merged
Conversation
|
Documentation for this PR has been generated and is available at: https://n0-computer.github.io/noq/pr/666/docs/noq/ Last updated: 2026-05-22T11:44:09Z |
805b5cb to
cad3bf8
Compare
Performance Comparison Report
|
| Scenario | noq | upstream | Delta | CPU (avg/max) |
|---|---|---|---|---|
| large-single | 5940.4 Mbps | 8039.1 Mbps | -26.1% | 98.7% / 150.0% |
| medium-concurrent | 5523.1 Mbps | 7768.0 Mbps | -28.9% | 92.5% / 97.4% |
| medium-single | 4461.4 Mbps | 4469.7 Mbps | ~0% | 93.8% / 102.0% |
| small-concurrent | 3886.3 Mbps | 5254.5 Mbps | -26.0% | 95.2% / 102.0% |
| small-single | 3597.1 Mbps | 4715.8 Mbps | -23.7% | 98.9% / 152.0% |
Netsim Benchmarks (network simulation)
| Condition | noq | upstream | Delta |
|---|---|---|---|
| ideal | 3159.7 Mbps | 3944.2 Mbps | -19.9% |
| lan | 782.4 Mbps | 810.3 Mbps | -3.4% |
| lossy | 63.4 Mbps | 56.5 Mbps | +12.2% |
| wan | 83.8 Mbps | 83.8 Mbps | ~0% |
Summary
noq is 21.8% slower on average
4a62e11cc9720588ed212feb04abe44dfff7c5c4 - artifacts
Raw Benchmarks (localhost)
| Scenario | noq | upstream | Delta | CPU (avg/max) |
|---|---|---|---|---|
| large-single | 5507.1 Mbps | 7892.7 Mbps | -30.2% | 98.2% / 150.0% |
| medium-concurrent | 5477.4 Mbps | 7680.8 Mbps | -28.7% | 92.2% / 97.4% |
| medium-single | 4166.2 Mbps | 4749.0 Mbps | -12.3% | 90.4% / 98.3% |
| small-concurrent | 3773.0 Mbps | 5351.3 Mbps | -29.5% | 95.6% / 103.0% |
| small-single | 3505.7 Mbps | 4885.4 Mbps | -28.2% | 94.7% / 102.0% |
Netsim Benchmarks (network simulation)
| Condition | noq | upstream | Delta |
|---|---|---|---|
| ideal | 3003.0 Mbps | 4140.2 Mbps | -27.5% |
| lan | 782.5 Mbps | 810.3 Mbps | -3.4% |
| lossy | 69.9 Mbps | 55.9 Mbps | +25.0% |
| wan | 83.8 Mbps | 83.8 Mbps | ~0% |
Summary
noq is 26.0% slower on average
8c36c2aaf7e17571a889d6523cf2bfa8fc7ac648 - artifacts
Raw Benchmarks (localhost)
| Scenario | noq | upstream | Delta | CPU (avg/max) |
|---|---|---|---|---|
| large-single | 5696.7 Mbps | 8044.8 Mbps | -29.2% | 92.7% / 97.8% |
| medium-concurrent | 5511.2 Mbps | 7623.0 Mbps | -27.7% | 94.1% / 99.7% |
| medium-single | 3683.7 Mbps | 4749.7 Mbps | -22.4% | 93.4% / 101.0% |
| small-concurrent | 3907.3 Mbps | 5256.4 Mbps | -25.7% | 96.7% / 153.0% |
| small-single | 3617.7 Mbps | 4685.1 Mbps | -22.8% | 98.6% / 154.0% |
Netsim Benchmarks (network simulation)
| Condition | noq | upstream | Delta |
|---|---|---|---|
| ideal | 3120.1 Mbps | 4078.7 Mbps | -23.5% |
| lan | 782.5 Mbps | 810.3 Mbps | -3.4% |
| lossy | 69.8 Mbps | 61.0 Mbps | +14.5% |
| wan | 83.8 Mbps | 83.8 Mbps | ~0% |
Summary
noq is 25.2% slower on average
a75fd99 to
6fc2f6e
Compare
cad3bf8 to
4a62e11
Compare
matheus23
approved these changes
May 21, 2026
Member
matheus23
left a comment
There was a problem hiding this comment.
I think my comments are mostly nits. This looks fine all in all. If you're crunched for time, feel free to just merge.
The RoutingTable is in charge of which addresses a TestEndpoint has. So now all decisions are made there remove the addr field and clean up any remaining usages. This should avoid confusion in the future.
4a62e11 to
8c36c2a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The RoutingTable is in charge of which addresses a TestEndpoint
has. So now all decisions are made there remove the addr field and
clean up any remaining usages. This should avoid confusion in the
future.
Breaking Changes
n/a
Notes & open questions
Maybe I'm finally done with cleaning up existing test infra. I'm
medium enthusiastic about this whole thing. I think it's an
improvement but there's definitely some things that look more complex
now. And some of the tests still do just plain weird stuff. Like when
opening a 2nd path we should now probably have a router that has a 2nd
path. But it was originally written without any router so cheated by
disconnecting the first path and relying on not reaching the
keep-alive interval or idle-timeout of the first path. So those are
still further improvements. But I need to work towards writing my
test, so I'll stop here.
Change checklist