Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds two metrics:
remote_holepunch_attemptcounts the number of remotes for which we initiated holepunching.remote_holepunch_successcounts the number of remotes where we initiated holepunching and had successBoth are either increased by 0 or 1 during the lifetime of a
RemoteStateActor, never more. We incrase_attemptonce on the first time when holepunching is initiated. We increase_successonce if a new IP path is opened whose remote address is part of the last holepunching round.I'm not entirely sure if this logic is fully sound, but it's the best I could come up with so far.
Fixes #3695
Breaking Changes
Notes & open questions
Change checklist
quic-rpciroh-gossipiroh-blobsdumbpipesendme