Skip to content

Conversation

@Frando
Copy link
Member

@Frando Frando commented Dec 8, 2025

Description

This adds two metrics:

  • remote_holepunch_attempt counts the number of remotes for which we initiated holepunching.
  • remote_holepunch_success counts the number of remotes where we initiated holepunching and had success

Both are either increased by 0 or 1 during the lifetime of a RemoteStateActor, never more. We incrase _attempt once on the first time when holepunching is initiated. We increase _success once if a new IP path is opened whose remote address is part of the last holepunching round.

I'm not entirely sure if this logic is fully sound, but it's the best I could come up with so far.

Fixes #3695

Breaking Changes

Notes & open questions

Change checklist

  • Self-review.
  • Documentation updates following the style guide, if relevant.
  • Tests if relevant.
  • All breaking changes documented.
    • List all breaking changes in the above "Breaking Changes" section.
    • Open an issue or PR on any number0 repos that are affected by this breaking change. Give guidance on how the updates should be handled or do the actual updates themselves. The major ones are:

@Frando Frando force-pushed the Frando/mp-metrics-hp branch from eff1c4b to acbc048 Compare December 8, 2025 13:35
@github-actions
Copy link

github-actions bot commented Dec 8, 2025

Documentation for this PR has been generated and is available at: https://n0-computer.github.io/iroh/pr/3748/docs/iroh/

Last updated: 2025-12-10T12:24:53Z

@n0bot n0bot bot added this to iroh Dec 8, 2025
@github-project-automation github-project-automation bot moved this to 🏗 In progress in iroh Dec 8, 2025
@Frando Frando force-pushed the Frando/mp-metrics-hp branch from ca85a9f to f6c5e49 Compare December 9, 2025 11:33
@Frando Frando marked this pull request as ready for review December 9, 2025 13:57
@Frando Frando changed the title draft: holepunch metrics feat: holepunch metrics Dec 9, 2025
@Frando Frando changed the title feat: holepunch metrics feat: basic holepunch metrics Dec 9, 2025
Base automatically changed from Frando/mp-metrics-basics to feat-multipath December 9, 2025 21:38
@Frando Frando force-pushed the Frando/mp-metrics-hp branch from 0a4ba70 to fed03ef Compare December 10, 2025 12:18
@Frando Frando requested a review from flub December 10, 2025 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: 🏗 In progress

Development

Successfully merging this pull request may close these issues.

2 participants