-
Notifications
You must be signed in to change notification settings - Fork 327
feat: improve RelayMap and RelayMode configuration #3734
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: feat-multipath
Are you sure you want to change the base?
Conversation
|
Documentation for this PR has been generated and is available at: https://n0-computer.github.io/iroh/pr/3734/docs/iroh/ Last updated: 2025-12-06T09:42:13Z |
Arqu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a nit
|
|
||
| let relays = RelayMap::try_from_iter([ | ||
| "https://use1-1.relay.n0.iroh.iroh.link/", | ||
| "https://euc1-1.relay.n0.iroh.iroh.link/", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are still inconsistent with our usage of . and / for the relay urls everywhere.
We should be sticking to .
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, we should stick to . in all examples.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And of course, defaults.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is not an example but a test, I a actually want to make sure that it also works without . tbh
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, wasn't super clear from that. I thought you wanted to do the same thing in 2 ways ie empty builder and pass it in from an iter.
| /// # use iroh_relay::RelayMap; | ||
| /// let map = | ||
| /// RelayMap::try_from_iter(["https://relay_0.cool.com", "https://relay_1.cool.com"]).unwrap(); | ||
| /// ``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
doc comment should probably point out that a default RelayConfig is used and that this means we'll assume the relay URL has QAD running on port 7842 or whatever relevant.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
8b53ca3 to
006c5f9
Compare
No description provided.