Conversation
|
We will get to merging it this week! |
There was a problem hiding this comment.
Pull request overview
This PR adds comprehensive documentation for the endpoint hooks feature in iroh. The new page explains how to intercept and control the connection-establishment process using lightweight hooks that can observe or reject connections at specific lifecycle points.
Key changes:
- Added endpoint hooks documentation page with concept explanation and code examples
- Integrated new page into documentation navigation structure
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| docs.json | Added connecting/endpoint-hooks to the navigation menu under the "connecting" section |
| connecting/endpoint-hooks.mdx | New documentation page covering endpoint hooks concepts, two complete working examples (observing and rejecting connections), and links to advanced examples in the iroh repository |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| ```rust | ||
| use iroh::{ | ||
| Endpoint, EndpointAddr, Watcher, |
There was a problem hiding this comment.
The Watcher import is unused in this example. Consider removing it to keep the example clean and focused.
| Endpoint, EndpointAddr, Watcher, | |
| Endpoint, EndpointAddr, |
There was a problem hiding this comment.
It is used, it's a trait and its methods are in use
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
@Frando is it safe to say that this will be available in iroh v.96 and later? |
yes |
2 participants
No description provided.