Fix compatibility with 1.44 #7
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR updates the HideSidebar extension to be compatible with version 1.44, replacing deprecated APIs and hooks with their modern equivalents.
- Replaces deprecated
Title::makeTitle()method withSpecialPage::getTitleFor()for creating special page URLs - Updates hook registration from deprecated
SkinBuildSidebartoSidebarBeforeOutput - Corrects the autoload class path to include the proper directory structure
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| includes/HideSidebar.hooks.php | Updates URL generation method for UserLogin special page |
| extension.json | Updates hook registration and fixes autoload class path |
| }, | ||
| "Hooks": { | ||
| "SkinBuildSidebar": "HideSidebarHooks::efHideSidebar" | ||
| "SidebarBeforeOutput": "HideSidebarHooks::efHideSidebar" |
There was a problem hiding this comment.
The hook signature for SidebarBeforeOutput may differ from SkinBuildSidebar. Please verify that the efHideSidebar method parameters are compatible with the new hook's expected signature.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there,
I have made some changes to make the extension compatible with 1.44 and I only tested the docker image.
Thanks
Samy