Skip to content

Fix task execution for certain configurations #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
alex-bach wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Fix task execution for certain configurations #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion gradle.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
version=0.4.0-SNAPSHOT
version=0.4.0.mysugr.2
group=org.jetbrains.kotlinx

kotlinVersion=1.4.30
Expand Down
15 changes: 11 additions & 4 deletions src/main/kotlin/BinaryCompatibilityValidatorPlugin.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,8 +83,9 @@ private fun Project.configureKotlinCompilation(
val projectName = project.name
val apiBuildDir = file(buildDir.resolve(API_DIR))
val apiBuild = task<KotlinApiBuildTask>("apiBuild", extension) {
// Do not enable task for empty umbrella modules
isEnabled = apiCheckEnabled(extension) && compilation.allKotlinSourceSets.any { it.kotlin.srcDirs.any { it.exists() } }
// Do not execute task for empty umbrella modules
onlyIf { compilation.allKotlinSourceSets.any { it.kotlin.srcDirs.any { it.exists() } } }
isEnabled = apiCheckEnabled(extension)
// 'group' is not specified deliberately so it will be hidden from ./gradlew tasks
description =
"Builds Kotlin API for 'main' compilations of $projectName. Complementary task and shouldn't be called manually"
Expand Down Expand Up @@ -131,7 +132,9 @@ private fun Project.configureCheckTasks(
val projectName = project.name
val apiCheckDir = file(projectDir.resolve(API_DIR))
val apiCheck = task<ApiCompareCompareTask>("apiCheck") {
isEnabled = apiCheckEnabled(extension) && apiBuild.map { it.enabled }.getOrElse(true)
// Do not execute task for empty umbrella modules
onlyIf { apiBuild.get().isOnlyIf() }
isEnabled = apiCheckEnabled(extension)
group = "verification"
description = "Checks signatures of public API against the golden value in API folder for $projectName"
projectApiDir = if (apiCheckDir.exists()) {
Expand All @@ -145,7 +148,9 @@ private fun Project.configureCheckTasks(
}

task<Sync>("apiDump") {
isEnabled = apiCheckEnabled(extension) && apiBuild.map { it.enabled }.getOrElse(true)
// Do not execute task for empty umbrella modules
onlyIf { apiBuild.get().isOnlyIf() }
isEnabled = apiCheckEnabled(extension)
group = "other"
description = "Syncs API from build dir to $API_DIR dir for $projectName"
from(apiBuildDir)
Expand All @@ -158,6 +163,8 @@ private fun Project.configureCheckTasks(
project.tasks.getByName("check").dependsOn(apiCheck)
}

private fun KotlinApiBuildTask.isOnlyIf(): Boolean = onlyIf.isSatisfiedBy(this)

inline fun <reified T : Task> Project.task(
name: String,
noinline configuration: T.() -> Unit
Expand Down