[ISSUE #96]✨Refine SIMD feature checks for string operations in CheetahString

[mxsm]

fix #96

Summary by CodeRabbit

Bug Fixes

• Fixed SIMD optimization logic to ensure optimized code paths only apply on x86_64 architecture when the SIMD feature is enabled, improving cross-platform compatibility and stability.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

Caution

Review failed

The pull request is closed.

📝 Walkthrough

Walkthrough

The pull request refines conditional compilation guards for SIMD-accelerated string operations in CheetahString, restricting SIMD implementations to x86_64 architecture when the simd feature is enabled while ensuring non-SIMD fallbacks apply to other architectures.

Changes

Cohort / File(s)

Summary

SIMD Architecture-Specific Compilation Guards src/cheetah_string.rs

Updated conditional compilation attributes for SIMD-accelerated string methods (starts_with, ends_with, contains, find, and PartialEq implementations). Replaced #[cfg(feature = "simd")] with #[cfg(all(feature = "simd", target_arch = "x86_64"))] and corresponding fallback guards from #[cfg(not(feature = "simd"))] to #[cfg(not(all(feature = "simd", target_arch = "x86_64")))] to ensure SIMD code only compiles on x86_64 when the feature is enabled.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Poem

🐰 Hops through x86 gates with glee,
SIMD paths now precise, you see—
Where rabbits dare, only x64 may run,
Fallbacks for all when SIMD's done! ✨

✨ Finishing touches

• 📝 Generate docstrings

---

📜 Recent review details

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8da5f8c and 72a5ab9.

📒 Files selected for processing (1)

• src/cheetah_string.rs

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[Copilot]

Pull request overview

This PR refines the SIMD feature checks in CheetahString to make them architecture-specific, ensuring SIMD operations are only enabled on x86_64 platforms where the SSE2 instructions are available. This aligns the conditional compilation flags in cheetah_string.rs with the actual SIMD implementation in the simd module.

Key Changes:

• Updated all SIMD-related cfg attributes to require both the simd feature flag AND x86_64 target architecture
• Applied consistently across string operations: starts_with, ends_with, contains, find, and all PartialEq implementations

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.