Open
Conversation
RomanPodymov
commented
Feb 15, 2026
| // Previously exposed a bridging crash in Swift | ||
| // NOTE nobody was brave enough or diligent enough to report this to Apple :{ | ||
| // NOTE no Linux test since this constructor doesn’t exist there | ||
| XCTAssertFalse(NSError().isCancelled) |
Collaborator
Author
There was a problem hiding this comment.
Hello @mxcl
It looks like this is now also crashing on macOS.
| @@ -76,14 +76,17 @@ class RaceTests: XCTestCase { | |||
| func testFulfilledWithNoWinner() { | |||
Collaborator
Author
There was a problem hiding this comment.
@mxcl Don't know why, but it was failing on Android.
|
Hope you liked the article 😅 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello.
Thank you for PromiseKit.
@Nikoloutsos proposed to use Parameter Packs, let's try it.
Fixes #1268.