Implementing Listening Obj type into MVR#150
Open
adragnevVW wants to merge 4 commits into
Open
Conversation
AndriiVoitenko
approved these changes
May 15, 2026
Collaborator
Author
|
Hi @ILane-VW & @AndriiVoitenko , |
|
I think we should stick to xml and not mix xml with JSON in the MVR. In VW I think it's fine to use JSON to store the data. I don't think we should store the data a a resource in the MVR when we can represent it with directly in the XML. |
Collaborator
Author
|
@klinzey Yeah, I agree with you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this change, we are only adding the Listening Plane object type to the MVR so that we can identify which object represents the Listening Plane. Once we confirm the exact data we want to store, we can update it accordingly.
The heatmap data is stored into the XML file attached to the Listening Plane Obj and stored into the MVR as a resource.