Move dev/unused dependencies to optional extras#4
Merged
Conversation
Remove ruff, pytest, pydeface, jupyterlab, ipywidgets, h5py, pillow, and lxml from runtime dependencies. None are imported by the package source code. ruff and pytest are moved to [dev] optional extras with correct version pins. The rest are dropped entirely. Closes #3 (partially) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Fix "fmriprepp" -> "fmriprep" typo in utils.py docstrings - Remove unreachable Python 3.8 fallback in io.py (min is 3.9) - Add node_modules/ to .gitignore Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Runs lint (ruff) and tests (pytest) on Python 3.9-3.12 via GitHub Actions on pushes and PRs to main/master. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Remove unused loop variables (B007) - Remove unused local variable (F841) - Fix line-too-long errors (E501) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ruff,pytest,pydeface,jupyterlab,ipywidgets,h5py,pillow, andlxmlfrom runtime dependencies (none are imported by the package source code)ruffandpytestto[dev]optional extras with correct version pins (fixes previous conflicting specs)pydeface,jupyterlab,ipywidgets,h5py,pillow,lxmlentirelyTest plan
uv syncinstalls successfully without dev extraspython -c "import hyperface"worksuv sync --extra dev && python -m pytest tests/ -q— 54 tests passPartially addresses #3
🤖 Generated with Claude Code