Skip to content

Conversation

@djthorpe
Copy link
Member

@djthorpe djthorpe commented Jan 11, 2026

This is a major release pull request that introduces OpenTelemetry tracing support throughout the codebase and refactors the queue management system. The PR updates the API from positional parameters to options-based configuration and consolidates the worker pool functionality.

Changes:

  • Added OpenTelemetry tracing integration for database queries and queue operations
  • Refactored Manager API to use options pattern (WithNamespace, WithTracer, etc.)
  • Removed standalone WorkerPool in favor of integrated Manager.Run() with Worker interface
  • Changed TaskMeta.Payload from any to json.RawMessage for type safety
  • Renamed Bind.Replace to internal methods and added public Query() method

Copilot AI review requested due to automatic review settings January 11, 2026 10:35
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This is a major release pull request that introduces OpenTelemetry tracing support throughout the codebase and refactors the queue management system. The PR updates the API from positional parameters to options-based configuration and consolidates the worker pool functionality.

Changes:

  • Added OpenTelemetry tracing integration for database queries and queue operations
  • Refactored Manager API to use options pattern (WithNamespace, WithTracer, etc.)
  • Removed standalone WorkerPool in favor of integrated Manager.Run() with Worker interface
  • Changed TaskMeta.Payload from any to json.RawMessage for type safety
  • Renamed Bind.Replace to internal methods and added public Query() method

Reviewed changes

Copilot reviewed 45 out of 46 changed files in this pull request and generated 12 comments.

Show a summary per file
File Description
tracer.go Added OTEL span support and context-based query tracking
queries.go Renamed Get() to Query() for clarity
bind.go Refactored to support OTEL span naming via Query() method
pool.go Updated to use new tracer struct
opts.go Added WithTracer() and WithNamespace() options
pkg/queue/manager.go Refactored to use options pattern and embed worker pool
pkg/queue/task.go Rewrote task loop to support concurrent workers with semaphore
pkg/queue/ticker.go Added new RunTickerLoop methods with handler callbacks
pkg/queue/run.go New file consolidating Worker interface and execution logic
pkg/queue/schema/*.go Changed Replace() to Query() and TaskMeta.Payload to json.RawMessage
cmd/pgqueue/*.go Added OTEL support to CLI commands
go.mod/go.sum Updated dependencies including pgx v5.8.0 and otel libraries

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 45 out of 46 changed files in this pull request and generated 7 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@djthorpe djthorpe requested a review from Copilot January 11, 2026 11:03
@djthorpe djthorpe changed the title Djt/0110/release Queue Manager Workerpool Jan 11, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 45 out of 46 changed files in this pull request and generated 2 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@djthorpe djthorpe merged commit 6f33d9d into main Jan 11, 2026
1 check passed
@djthorpe djthorpe deleted the djt/0110/release branch January 11, 2026 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants