-
Notifications
You must be signed in to change notification settings - Fork 0
Queue Manager Workerpool #24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This is a major release pull request that introduces OpenTelemetry tracing support throughout the codebase and refactors the queue management system. The PR updates the API from positional parameters to options-based configuration and consolidates the worker pool functionality.
Changes:
- Added OpenTelemetry tracing integration for database queries and queue operations
- Refactored Manager API to use options pattern (WithNamespace, WithTracer, etc.)
- Removed standalone WorkerPool in favor of integrated Manager.Run() with Worker interface
- Changed TaskMeta.Payload from
anytojson.RawMessagefor type safety - Renamed Bind.Replace to internal methods and added public Query() method
Reviewed changes
Copilot reviewed 45 out of 46 changed files in this pull request and generated 12 comments.
Show a summary per file
| File | Description |
|---|---|
| tracer.go | Added OTEL span support and context-based query tracking |
| queries.go | Renamed Get() to Query() for clarity |
| bind.go | Refactored to support OTEL span naming via Query() method |
| pool.go | Updated to use new tracer struct |
| opts.go | Added WithTracer() and WithNamespace() options |
| pkg/queue/manager.go | Refactored to use options pattern and embed worker pool |
| pkg/queue/task.go | Rewrote task loop to support concurrent workers with semaphore |
| pkg/queue/ticker.go | Added new RunTickerLoop methods with handler callbacks |
| pkg/queue/run.go | New file consolidating Worker interface and execution logic |
| pkg/queue/schema/*.go | Changed Replace() to Query() and TaskMeta.Payload to json.RawMessage |
| cmd/pgqueue/*.go | Added OTEL support to CLI commands |
| go.mod/go.sum | Updated dependencies including pgx v5.8.0 and otel libraries |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 45 out of 46 changed files in this pull request and generated 7 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 45 out of 46 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This is a major release pull request that introduces OpenTelemetry tracing support throughout the codebase and refactors the queue management system. The PR updates the API from positional parameters to options-based configuration and consolidates the worker pool functionality.
Changes: