Configs by round for P2P NumFloodingRounds #7573
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## feat/supernova-async-exec #7573 +/- ##
==========================================================
Coverage 77.68% 77.69%
==========================================================
Files 876 876
Lines 120949 120996 +47
==========================================================
+ Hits 93961 94004 +43
+ Misses 20794 20787 -7
- Partials 6194 6205 +11 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| @@ -0,0 +1,9 @@ | |||
| package dto | |||
|
|
|||
| type ConfigVariable string | |||
Contributor
Author
There was a problem hiding this comment.
Right, added them
| ) | ||
| } | ||
|
|
||
| func (pce *processConfigsByEpoch) GetValue(variable dto.ConfigVariable) uint64 { |
Contributor
Author
There was a problem hiding this comment.
Right, added it
| return nil | ||
| } | ||
|
|
||
| // TODO: We should probably get rid of all these functions and use only GetValue func, similar to how enableEpochsHandler works |
…nd-num-flooding-rounds-2
…nd-num-flooding-rounds-2
sstanculeanu
approved these changes
Jan 8, 2026
mradian1
approved these changes
Jan 8, 2026
…nd-num-flooding-rounds-2
mariusmihaic
merged commit 1e217d8
into
feat/supernova-async-exec
10 of 11 checks passed
mariusmihaic
deleted the
MX-17392-configs-by-round-num-flooding-rounds-2
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasoning behind the pull request
NumFloodingRoundstoProcessConfigsByRoundProposed changes
GetValue(variable dto.ConfigVariable)functionality inprocessConfigsByEpochto resemble a bitenableEpochsHandler, such that instead of having N methods (Get var x/y/z), we only have one method that we can call for a specific value flagroundNotifierinprocessConfigsByEpochTesting procedure
Pre-requisites
Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:
featbranch created?featbranch merging, do all satellite projects have a proper tag insidego.mod?