Fix hugely popular crash in RpAnimBlendAllocateData (SA 0x000D5F6F)#4894
Open
Dutchman101 wants to merge 2 commits intomultitheftauto:masterfrom
Open
Fix hugely popular crash in RpAnimBlendAllocateData (SA 0x000D5F6F)#4894Dutchman101 wants to merge 2 commits intomultitheftauto:masterfrom
Dutchman101 wants to merge 2 commits intomultitheftauto:masterfrom
Conversation
qaisjp
reviewed
May 8, 2026
Member
There was a problem hiding this comment.
The code changes here seem to be guarding against m_pModelInfo pointing to invalid data, but do we know why it's invalid in the first place?
Member
There was a problem hiding this comment.
(Seems like a use after free or something?)
qaisjp
reviewed
May 8, 2026
Comment on lines
+2913
to
+2918
| #define HOOKPOS_CAnimBlendAssocGroup_CreateAssociations 0x4CE2F7 | ||
| #define HOOKSIZE_CAnimBlendAssocGroup_CreateAssociations 7 | ||
| #define HOOKCHECK_CAnimBlendAssocGroup_CreateAssociations 0x8B | ||
| DWORD RETURN_CAnimBlendAssocGroup_CreateAssociations = 0x4CE2FE; | ||
| DWORD RETURN_CAnimBlendAssocGroup_CreateAssociations_Skip = 0x4CE36F; | ||
| void _declspec(naked) HOOK_CAnimBlendAssocGroup_CreateAssociations() |
Member
There was a problem hiding this comment.
Please could you write some comments explaining exactly what the hook does?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes all paths i could trace for a very common crash, according to crash stats.
There's not much to say, other than that the pre-existing hook meant to avert this crash wasn't sufficient, but now it is.