Show minimum version in update dialog#4888
Open
omar-o22 wants to merge 3 commits intomultitheftauto:masterfrom
Open
Show minimum version in update dialog#4888omar-o22 wants to merge 3 commits intomultitheftauto:masterfrom
omar-o22 wants to merge 3 commits intomultitheftauto:masterfrom
Conversation
qaisjp
reviewed
May 4, 2026
Contributor
Author
fixed |
qaisjp
approved these changes
May 10, 2026
There was a problem hiding this comment.
Pull request overview
Updates the client-side mandatory update prompt shown when a server rejects a connection due to minclientversion, so the dialog includes the required version string provided by the server.
Changes:
- Updated the “MANDATORY UPDATE” dialog message to include the server-provided required client version.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| GetQuestionBox().Reset(); | ||
| GetQuestionBox().SetTitle(_("MANDATORY UPDATE")); | ||
| GetQuestionBox().SetMessage(_("To join this server, you must update MTA.\n\n Do you want to update now ?")); | ||
| GetQuestionBox().SetMessage(SString(_("To join this server, you must update MTA to version %s.\n Do you want to update now?"), *m_strServerSaysData)); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Displays the minimum required client version in the update dialog when a user tries joins a server with a higher
minclientversion.Motivation
Sometimes users update failures, displaying the required client version helps anyone assisting them identify which version is needed, so it can be installed manually.
Test plan
minclientversionthan the client.Checklist