Add/extend batch verifier tests for header parsing, filtered manifest export, and export UX#292
Open
multiplex55 wants to merge 1 commit intoverifyfrom
Open
Add/extend batch verifier tests for header parsing, filtered manifest export, and export UX#292multiplex55 wants to merge 1 commit intoverifyfrom
multiplex55 wants to merge 1 commit intoverifyfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
parsing.test.tsto verify buy/sell station parsing, numeric parsing of comma-formatted jumps and cargo values, and safe handling when header lines are missing.filteredManifest.test.tsthat verifies rows with statesdo_not_buy,quantity_mismatch, andmissing_from_exportare excluded, that original manifest order is preserved for safe rows, that rejected rows are excluded from the multibuy block, and that totals (items, capital, gross sell, volume, ISK/jump) and adjusted-profit calculations are recomputed using export buy values (Option B) with correct formatting.BatchBuyVerifier.test.tsxto assert adjusted buy-plan metrics render when exclusions exist, that the Export action copies the filtered manifest (only safe rows, preserved order), that export is disabled when no safe rows exist, and that duplicate-name warnings disable export.frontend/src/features/batchVerifier/__tests__/parsing.test.ts,frontend/src/features/batchVerifier/__tests__/filteredManifest.test.ts(new), andfrontend/src/features/batchVerifier/__tests__/BatchBuyVerifier.test.tsx(extended).Testing
npm -C frontend run test -- src/features/batchVerifier/__tests__/parsing.test.ts src/features/batchVerifier/__tests__/filteredManifest.test.ts src/features/batchVerifier/__tests__/BatchBuyVerifier.test.tsx.Codex Task