Skip to content

fix(id_mapping): fix typo taxId -> taxid #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Rapsssito wants to merge 3 commits into from
Closed

fix(id_mapping): fix typo taxId -> taxid #40

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6080de9
fix(id_mapping): fix typo taxId -> taxid
Rapsssito Jun 17, 2025
385989d
Merge branch 'multimeric:master' into patch-1
Rapsssito Jun 18, 2025
4f7ae8c
Update test_id_mapping.py
Rapsssito Jun 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions test/test_id_mapping/test_id_mapping.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,3 +184,13 @@ def test_taxon_id_all():
assert "P0CI39" in results
# Mouse gene
assert "P14719" in results

def test_taxon_id_different_database():
# Checks that the taxId parameter works in different databases (P38398 comes from human BRCA1)
request = IdMappingClient.submit(
source="UniProtKB_AC-ID", dest="Ensembl_Protein", ids={"P38398"}, taxon_id=9606
)
sleep(5)
results = {result["to"] for result in request.each_result()}
assert len(results) >= 1
assert "ENSP00000312236.5" in results
2 changes: 1 addition & 1 deletion unipressed/id_mapping/core.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ def _submit(
) -> requests.Response:
data: dict[str, Any] = {"ids": ",".join(ids), "from": source, "to": dest}
if taxon_id is not None:
data["taxId"] = taxon_id
data["taxid"] = taxon_id
return requests.post(
"https://rest.uniprot.org/idmapping/run",
data=data,
Expand Down