wip: refactoring of GUI building #34
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hansu
force-pushed
the
refactor-build-gui
branch
5 times, most recently
from
dff672c to
0512850
Compare
hansu
force-pushed
the
refactor-build-gui
branch
from
0512850 to
0f44696
Compare
Contributor
Author
|
So silent here. Just wanna make sure you didn't miss this one ;-) |
Owner
|
habe es gesehen, aber im moment fehlt mir die zeit |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bit refactoring of the parts that build the left hand side tabs of the GUI.
Mainly eliminating 130 lines of duplicated code from the create_*_setup functions.
Additionally I changed a bit the organisation of the tabs.
Now an extra tab for "Setup" to avoid to many sub-tabs in "General" so the sub tabs fit better the available width.
Also the tool table is now shown for layer and object as well. Very handy for adjusting the tool parameters from the table. BUT currently when selecting a tool via the table e.g. in "Objects", it updates the global tool. This needs to be fixed.