Skip to content

Tidy up project #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ianopolous merged 3 commits into from
Jan 22, 2026
Merged

Tidy up project #54

ianopolous merged 3 commits into from
Jan 22, 2026

Conversation

@cstamas
Copy link
Contributor

@cstamas cstamas commented Jan 21, 2026 •
edited
Loading

Apply same set of changes as to https://github.com/ipfs-shipyard/java-ipfs-http-client

Changes:

  • GH workflow updates (Java 21, use mvnw)
  • GH dependabot enabled for Maven as well
  • apply same .mvn/maven.config (but no checksum as there are no deps)
  • use wrapper + enable sha256 distro checksum
  • reformat same way as ipfs-http-client
  • update to Junit 6.0.2 (drop hamcrest; is unused)
  • no Java source code changes (sans reformat)

Dependency uses SNAPSHOT of multibase (will fail on CI).

@cstamas
Apply same set of changes as to https://github.com/ipfs-shipyard/java…
ab6f25b 
…-ipfs-http-client

Changes:
* GH workflow updates (Java 21, use mvnw)
* GH dependabot enabled for Maven as well
* apply same .mvn/maven.config (but no checksum as there are no deps)
* use wrapper + enable sha256 distro checksum
* reformat same way as ipfs-http-client
* update to Junit 6.0.2 (drop hamcrest; is unused)
* no Java source code changes (sans reformat)

Dependency uses SNAPSHOT of multibase (will fail on CI).
@cstamas cstamas changed the title Apply same set of changes as to https://github.com/ipfs-shipyard/java… Tidy up project Jan 21, 2026
ianopolous
ianopolous approved these changes Jan 21, 2026
View reviewed changes
Copy link
Member

@ianopolous ianopolous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@cstamas
Copy link
Contributor Author

cstamas commented Jan 21, 2026

So what now (re SNAPSHOT)? We gonna perform tidy-ups and releases in lockstep? Or any other idea?

Before doing that, we may want to lay down names? Are module names mentioned in PR https://github.com/ipfs-shipyard/java-ipfs-http-client/pull/269/changes okay?

@ianopolous
Copy link
Member

ianopolous commented Jan 21, 2026

Lockstep is fine by me. And those module names look fine.

@cstamas
Copy link
Contributor Author

cstamas commented Jan 21, 2026

Right. There is another problem: The v prefix for versions caused errors in JPMS

Caused by: java.lang.IllegalArgumentException: error: bad value for --module-version option: 'v1.3.0-SNAPSHOT'
    at com.sun.tools.javac.main.Arguments.error (Arguments.java:902)
    at com.sun.tools.javac.main.Arguments.doProcessArgs (Arguments.java:384)
    at com.sun.tools.javac.main.Arguments.processArgs (Arguments.java:348)
    at com.sun.tools.javac.main.Arguments.init (Arguments.java:247)
    at com.sun.tools.javac.api.JavacTool.getTask (JavacTool.java:191)
    at com.sun.tools.javac.api.JavacTool.getTask (JavacTool.java:119)
    at com.sun.tools.javac.api.JavacTool.getTask (JavacTool.java:68)
    at org.codehaus.plexus.compiler.javac.JavaxToolsCompiler.compileInProcess (JavaxToolsCompiler.java:125)

So I removed those, but that will cause breakage

@cstamas
Copy link
Contributor Author

cstamas commented Jan 21, 2026

Discuss it here multiformats/java-multibase#48

@cstamas
Copy link
Contributor Author

cstamas commented Jan 21, 2026 •
edited
Loading

Just as a demo, pushed more: snapshots are now shared via IPFS. Repository (for demo purposes) is:
https://ipfs.io/ipns/ipfs.maveniverse.eu/repository-ipfs-snapshots

@cstamas
Copy link
Contributor Author

cstamas commented Jan 22, 2026

Ok, changes pushed:

  • undone IPFS experiment
  • back to original "tidy up"
  • using java-multibase 1.3.0 from jitpack.io

@cstamas cstamas mentioned this pull request Jan 22, 2026
Closed
@cstamas
Copy link
Contributor Author

cstamas commented Jan 22, 2026

If merging this, please squash merge (or ping me to squash beforehand)

@cstamas cstamas requested a review from ianopolous January 22, 2026 12:43
@ianopolous ianopolous merged commit 4bc593f into multiformats:master Jan 22, 2026
1 check passed
@cstamas cstamas deleted the tidy-up branch January 22, 2026 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ianopolous ianopolous ianopolous approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@cstamas @ianopolous