Fpl basecase #53
Closed
Fpl basecase #53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rization. Use _attr_optimize_finite_math.
* python/src/moocore/_moocore.py: Use it.
(check_hvc): check also maximise=True.
…nused. * c/mt19937/mt19937.h: Remove declarations.
…ization and vectorization.
updates: - [github.com/lorenzwalthert/precommit: v0.4.3.9014 → v0.4.3.9017](lorenzwalthert/precommit@v0.4.3.9014...v0.4.3.9017) - [github.com/tox-dev/tox-ini-fmt: 1.6.0 → 1.7.0](tox-dev/tox-ini-fmt@1.6.0...1.7.0) - [github.com/tox-dev/pyproject-fmt: v2.6.0 → v2.11.0](tox-dev/pyproject-fmt@v2.6.0...v2.11.0) - [github.com/astral-sh/ruff-pre-commit: v0.13.0 → v0.14.3](astral-sh/ruff-pre-commit@v0.13.0...v0.14.3) - [github.com/sphinx-contrib/sphinx-lint: v1.0.0 → v1.0.1](sphinx-contrib/sphinx-lint@v1.0.0...v1.0.1)
for more information, see https://pre-commit.ci
(print_rect): Rename to debug_print_rect.
* c/hv_priv.h: Remove x_aux from dlnote_t, x is const again.
* c/hv.c:
- Remove references to x_aux.
- Also maintain a list sorted according to z coordinate.
- Allocate (once) the auxiliar data structures used in the base case.
* c/hv4d_priv.h (onec4dplusU):
- Reconstruct the 3D base of the 4D contribution by sweeping the (sorted) z list.
- Use an auxiliar dlnode_t list (list_aux) and an auxiliar double vector (x_aux) for modified points.
- Take advantage of sweeping points in ascending order of the z-coordinate (continue_base_update_z_closest).
(fpli_hv4d): Delete unused. * c/hv4d_priv.h: Simplify code, fix warnings, add more asserts and comments. (update_bound_3d): New.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #53 +/- ##
==========================================
+ Coverage 72.52% 73.44% +0.92%
==========================================
Files 57 58 +1
Lines 4869 5068 +199
Branches 926 985 +59
==========================================
+ Hits 3531 3722 +191
+ Misses 991 965 -26
- Partials 347 381 +34
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.