Deadlock condition in graphclient on subscribe/unsubscribe#94
Merged
Conversation
added 2 commits
May 8, 2026 15:09
…ead websocket listener on unsubscribe event
rschlaikjer
approved these changes
May 8, 2026
woswos
requested changes
May 8, 2026
gcccai
reviewed
May 8, 2026
gcccai
approved these changes
May 8, 2026
woswos
requested changes
May 11, 2026
Member
|
Pipeline #1903871 |
woswos
approved these changes
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found a deadlock condition when trying to unsubscribe using the client
UnsubscribeGraphAPI-> acquiresself._subscriptionLockself._backgroundThread.RunCoroutine(_Unsubscribe()).result()- still holding_subscriptionLock..result()blocks the main thread until the coroutine returns -> we are waiting for this under lock3. On the background thread's event loop, _Unsubscribe runs and reaches
await self._CloseWebSocket()->await self._webSocket.close(). That await yields control back to the event loop.4. now yielded, the sleeping
_ListenToWebSocketfunction wakes up because the websocket just_ListenToWebSocketexception handler executes with self._subscriptionLock: - synchronous threading.Lock. The main thread holds it, so the background thread blocks here and freezes. The entire event loop is now blocked - no further awaits can move now_Unsubscribeawait self._webSocket.close()never gets to return, so .result() on the main thread never completes. Main thread keeps holding_subscriptionLock. Stuck.Error on sigterm