[code-infra] Migrate to vite from webpack for e2e tests#48248
Merged
brijeshb42 merged 7 commits intomui:masterfrom Apr 13, 2026
Merged
[code-infra] Migrate to vite from webpack for e2e tests#48248brijeshb42 merged 7 commits intomui:masterfrom
brijeshb42 merged 7 commits intomui:masterfrom
Conversation
brijeshb42
added
the
scope: code-infra
Netlify deploy previewhttps://deploy-preview-48248--material-ui.netlify.app/ Bundle size report
|
brijeshb42
force-pushed
the
e2e-vite
branch
2 times, most recently
from
b863412 to
0af2982
Compare
Member
ZeeshanTamboli
left a comment
ZeeshanTamboli
left a comment
There was a problem hiding this comment.
Two points:
- Need to update the e2e test's README (script name updates, "webpack bundle" mention).
- Error message in
test/e2e/index.test.tsneed to be updated with the new script names.
| react(), | ||
| ], | ||
| define: { | ||
| 'process.env': '{}', |
brijeshb42
force-pushed
the
e2e-vite
branch
2 times, most recently
from
ce54e41 to
0c1b9bb
Compare
Janpot
reviewed
Apr 13, 2026
test/e2e/package.json
Outdated
| "scripts": { | ||
| "start": "cross-env NODE_ENV=production pnpm build && concurrently --success first --kill-others \"pnpm run test\" \"pnpm run server\"", | ||
| "build": "vite build", | ||
| "dev": "concurrently \"pnpm run build --watch\" \"pnpm run server\"", |
Janpot
reviewed
Apr 13, 2026
| keepNames: true, | ||
| }, | ||
| plugins: [ | ||
| { |
Member
There was a problem hiding this comment.
Note: We could bring this plugin to the test utils package since we're using it in several places
Contributor
Author
There was a problem hiding this comment.
I'll add separately.
Janpot
approved these changes
Apr 13, 2026
Member
Janpot
left a comment
Janpot
left a comment
There was a problem hiding this comment.
few comments, nothing blocking
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Gets rid of webpack and related dependencies.