[PoC][docs] Simplify asset update across websites#48246
Draft
alexfauquette wants to merge 1 commit intomui:masterfrom
Draft
[PoC][docs] Simplify asset update across websites#48246alexfauquette wants to merge 1 commit intomui:masterfrom
alexfauquette wants to merge 1 commit intomui:masterfrom
Conversation
Netlify deploy previewhttps://deploy-preview-48246--material-ui.netlify.app/ Bundle size report
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Most of our docs are independent website with common aspects.
They share some code thanks to the docs packages. But updating such a package can be tricky, because it contains code, and dependencies. So during a breaking change period, you might want to be carrefull about updating them.
The idea is to extract the shared static assets (for now sponsors, but available versions, or banners could be added) in a dedicated packages references as a github repository could be done in one place, and all docs could update easily with a limited risk of breaking changes.
Another option could be to use a
getStaticPropsto download those info at build time