Skip to content

[docs-infra] Migrate docs app container/frame components#48182

Merged
brijeshb42 merged 28 commits intomui:masterfrom
brijeshb42:docs-infra-apipage
Apr 8, 2026
Merged

[docs-infra] Migrate docs app container/frame components#48182
brijeshb42 merged 28 commits intomui:masterfrom
brijeshb42:docs-infra-apipage

Conversation

@brijeshb42
Copy link
Copy Markdown
Contributor

@brijeshb42 brijeshb42 commented Apr 2, 2026 •
edited
Loading

The final result here is that now ApiPage component gets moved to the package which is 1/3rd of the remaining direct docs import in mui-x.
Next PR will tackle MarkdownDocs which would then move the needle to 99% migration.

@brijeshb42 brijeshb42 added the scope: docs-infra Involves the docs-infra product (https://www.notion.so/mui-org/b9f676062eb94747b6768209f7751305). label Apr 2, 2026
@mui-bot
Copy link
Copy Markdown

mui-bot commented Apr 2, 2026 •
edited
Loading

Netlify deploy preview

https://deploy-preview-48182--material-ui.netlify.app/

Bundle size report

Bundle Parsed size Gzip size
@mui/material 0B(0.00%) 0B(0.00%)
@mui/lab 0B(0.00%) 0B(0.00%)
@mui/system 0B(0.00%) 0B(0.00%)
@mui/utils 0B(0.00%) 0B(0.00%)

Details of bundle changes

Generated by 🚫 dangerJS against 746c760

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged. label Apr 3, 2026
@brijeshb42 brijeshb42 force-pushed the docs-infra-apipage branch from 0338a28 to 627c456 Compare April 3, 2026 09:57
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged. label Apr 3, 2026
@brijeshb42 brijeshb42 requested review from a team April 3, 2026 09:58
@brijeshb42 brijeshb42 force-pushed the docs-infra-apipage branch 3 times, most recently from fc8c953 to dd91780 Compare April 6, 2026 06:36
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged. label Apr 6, 2026
@brijeshb42 brijeshb42 force-pushed the docs-infra-apipage branch from dd91780 to 614413c Compare April 6, 2026 10:56
@github-actions github-actions bot added PR: out-of-date The pull request has merge conflicts and can't be merged. and removed PR: out-of-date The pull request has merge conflicts and can't be merged. labels Apr 6, 2026
@brijeshb42 brijeshb42 force-pushed the docs-infra-apipage branch from 614413c to b66b14f Compare April 6, 2026 12:00
@github-actions github-actions bot added PR: out-of-date The pull request has merge conflicts and can't be merged. and removed PR: out-of-date The pull request has merge conflicts and can't be merged. labels Apr 6, 2026
@brijeshb42 brijeshb42 force-pushed the docs-infra-apipage branch from b66b14f to 3ea1b58 Compare April 6, 2026 14:23
@github-actions github-actions bot added PR: out-of-date The pull request has merge conflicts and can't be merged. and removed PR: out-of-date The pull request has merge conflicts and can't be merged. labels Apr 6, 2026
Janpot
Janpot reviewed Apr 7, 2026
View reviewed changes
Comment thread packages-internal/core-docs/package.json
"react-simple-code-editor": "^0.14.1",
"styled-components": "^5.3.0 || ^6.0.0"
},
"peerDependenciesMeta": {
Copy link
Copy Markdown
Member

@Janpot Janpot Apr 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are there optional peer deps? We have only one dependant of this package.

Copy link
Copy Markdown
Contributor Author

@brijeshb42 brijeshb42 Apr 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated to just keep styled-components as optional since it is actually not needed in x.

Janpot
Janpot approved these changes Apr 7, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@Janpot Janpot left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would remove peerDependenciesMeta unless there is good reason to keep it.

@brijeshb42 brijeshb42 force-pushed the docs-infra-apipage branch from 3ea1b58 to 860f1eb Compare April 7, 2026 14:15
@github-actions github-actions bot added PR: out-of-date The pull request has merge conflicts and can't be merged. and removed PR: out-of-date The pull request has merge conflicts and can't be merged. labels Apr 7, 2026
brijeshb42 added 23 commits April 8, 2026 11:05
@brijeshb42
Move AppFrame
6d21cfb
@brijeshb42
Migrate AppSettingsDrawer
aefa8db
@brijeshb42
Migrated Notifications component with folder restructuring
2a963b2
@brijeshb42
Moved SearchButton
795da3c
@brijeshb42
Moved AppSearch components
940c59a
@brijeshb42
Migrate AppFrame and small cleanup
eb53f4c
@brijeshb42
Move stylingSolutionMapping to constants
0818678
@brijeshb42
Move App banner components, theming and featureToggle
609810d
@brijeshb42
Migrate AppLayoutDocsFooter and EditPage
82cb78b
@brijeshb42
Move docs/config file to the core-docs package
1e827aa 
Refactored around it a bit to provider default value from the
DocsProvider context
@brijeshb42
Remove AppFramw wrapper in docs
f7672a5 
Refactor how notifications are fetch. default hardcoded to fetch from
url. Can be overridden to provide custom fetcher.
@brijeshb42
Remove prop-types usage and dependency
cfc8b96
@brijeshb42
Move BackToTop component
82b9856
@brijeshb42
Migrate Demo infra components
2a0c8c5
@brijeshb42
Migrate TableOfContents components
b38db90
@brijeshb42
Remove local Head component wrapper and directly use from package
869b16b
@brijeshb42
Move AppLayoutDocs
4e12e6f 
Final piece before ApiPage can be migrated
@brijeshb42
Migrate ApiPage component
4459557
@brijeshb42
Fix BackToTop component
00c0910
@brijeshb42
CI Fix
60f12ba
@brijeshb42
Fix docs:i18n script
ac4f969
@brijeshb42
Dedupe
345bd0d
@brijeshb42
Refactor optional peer deps
746c760
@brijeshb42 brijeshb42 force-pushed the docs-infra-apipage branch from 860f1eb to 746c760 Compare April 8, 2026 05:36
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged. label Apr 8, 2026
@brijeshb42 brijeshb42 merged commit e518e8b into mui:master Apr 8, 2026
23 checks passed
@brijeshb42 brijeshb42 deleted the docs-infra-apipage branch April 8, 2026 07:14
brijeshb42 added a commit to brijeshb42/material-ui that referenced this pull request Apr 8, 2026
@brijeshb42 @claude
Revert "[docs-infra] Migrate docs app container/frame components (mui…
d537d7c 
…#48182)"

This reverts commit e518e8b.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Janpot Janpot Janpot approved these changes

Assignees

No one assigned

Labels

scope: docs-infra Involves the docs-infra product (https://www.notion.so/mui-org/b9f676062eb94747b6768209f7751305).

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@brijeshb42 @mui-bot @Janpot