You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Fixes onClick handlers on NumberFieldScrubArea and its children by manually dispatching click events when pointer movement doesn't occur. The fix addresses issue #2761 where event.preventDefault() on pointerdown was preventing browser click events.
Tracks pointer movement with didMoveRef to distinguish clicks from scrubs
Stores original target with pointerDownTargetRef to dispatch click to correct element
Manually dispatches synthetic click event when pointer up occurs without movement
Adds test coverage for both direct clicks and clicks on child elements
Confidence Score: 5/5
This PR is safe to merge with minimal risk
The implementation is clean and follows standard patterns for handling prevented default behavior. The fix properly tracks state with refs, correctly dispatches synthetic events, and includes comprehensive test coverage for both the direct and child element click scenarios.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preview: https://stackblitz.com/edit/y7g8yeat?file=src%2FApp.tsx
Fixes #2761