Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/metal-bottles-swim.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"tanstack-query-optimistic-updates": patch
---

- [PR](https://github.com/mugglim/tanstack-query-optimistic-updates/pull/9)
10 changes: 5 additions & 5 deletions src/react/__tests__/useOptimisticMutation.test.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ describe("useOptimisticMutation", () => {
mutationFn: () => Promise.resolve(),
optimisticUpdateOptions: {
queryKey: MOCK_QUERY_DATA.todo.queryKey,
optimisticUpdatesFn: ({ prevQueryData, variables }: { prevQueryData: Todo[]; variables: Todo }) => {
getOptimisticState: ({ prevQueryData, variables }: { prevQueryData: Todo[]; variables: Todo }) => {
return [...prevQueryData, variables];
}
}
Expand Down Expand Up @@ -68,7 +68,7 @@ describe("useOptimisticMutation", () => {
mutationFn: () => Promise.reject(),
optimisticUpdateOptions: {
queryKey: MOCK_QUERY_DATA.todo.queryKey,
optimisticUpdatesFn: ({ prevQueryData, variables }: { prevQueryData: Todo[]; variables: Todo }) => {
getOptimisticState: ({ prevQueryData, variables }: { prevQueryData: Todo[]; variables: Todo }) => {
return [...prevQueryData, variables];
}
}
Expand Down Expand Up @@ -114,7 +114,7 @@ describe("useOptimisticMutation", () => {
mutationFn: () => Promise.resolve(),
optimisticUpdateOptions: {
queryKey: MOCK_QUERY_DATA.todo.queryKey,
optimisticUpdatesFn: ({ prevQueryData, variables }: { prevQueryData: Todo[]; variables: Todo }) => {
getOptimisticState: ({ prevQueryData, variables }: { prevQueryData: Todo[]; variables: Todo }) => {
return [...prevQueryData, variables];
},
invalidateQueryOnSuccess: true
Expand Down Expand Up @@ -154,7 +154,7 @@ describe("useOptimisticMutation", () => {
mutationFn: () => Promise.resolve(),
optimisticUpdateOptions: {
queryKey: MOCK_QUERY_DATA.todo.queryKey,
optimisticUpdatesFn: ({ prevQueryData, variables }: { prevQueryData: Todo[]; variables: Todo }) => {
getOptimisticState: ({ prevQueryData, variables }: { prevQueryData: Todo[]; variables: Todo }) => {
return [...prevQueryData, variables];
},
invalidateQueryOnSuccess: () => {
Expand Down Expand Up @@ -194,7 +194,7 @@ describe("useOptimisticMutation", () => {
mutationFn: () => Promise.resolve(),
optimisticUpdateOptions: {
queryKey: MOCK_QUERY_DATA.todo.queryKey,
optimisticUpdatesFn: updateFnMock
getOptimisticState: updateFnMock
}
});

Expand Down
13 changes: 1 addition & 12 deletions src/react/useOptimisticMutation/types.ts
Original file line number Diff line number Diff line change
@@ -1,20 +1,9 @@
import { QueryKey } from "@tanstack/react-query";

export type OptimisticUpdateOptions<TQueryData = unknown, TVariables = void> = {
/**
* A query key for optimistic update
*/
queryKey: QueryKey;
/**
* A function returns the resulting optimistic state.
*/
optimisticUpdatesFn: (param: { prevQueryData: TQueryData; variables: TVariables }) => TQueryData;
/**
* If set to `true`, the query will fetch if the data is stale.
*
* @default false
*/
invalidateQueryOnSuccess?: boolean | (() => boolean);
getOptimisticState: (param: { prevQueryData: TQueryData; variables: TVariables }) => TQueryData;
};

export type OptimisticUpdateContext = {
Expand Down
4 changes: 2 additions & 2 deletions src/react/useOptimisticMutation/useOptimisticMutation.ts
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ export function useOptimisticMutation<TData = unknown, TError = DefaultError, TV
const {
queryKey: optimisticUpdateQueryKey,
invalidateQueryOnSuccess = false,
optimisticUpdatesFn
getOptimisticState
} = optimisticUpdateOptions;

return useMutation<TData, TError, TVariables, OptimisticUpdateContext>(
Expand All @@ -35,7 +35,7 @@ export function useOptimisticMutation<TData = unknown, TError = DefaultError, TV
return;
}

const optimisticQueryData = optimisticUpdatesFn({ prevQueryData, variables });
const optimisticQueryData = getOptimisticState({ prevQueryData, variables });

client.setQueryData(optimisticUpdateQueryKey, optimisticQueryData);
onMutate?.(variables);
Expand Down