Open
Conversation
✅ Deploy Preview for localai ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Signed-off-by: devmanishofficial <devmanishofficial@gmail.com>
DEVMANISHOFFL
force-pushed
the
feat/web-search-schema
branch
from
a5d7863 to
e5387d9
Compare
Signed-off-by: devmanishofficial <devmanishofficial@gmail.com>
mudler
reviewed
Jan 7, 2026
| } | ||
|
|
||
| func (s *SimpleSearch) Search(ctx context.Context, query string) ([]schema.UrlCitation, error) { | ||
| // TODO: Implement actual DuckDuckGo, Google Custom Search, or browsing logic here. |
Owner
There was a problem hiding this comment.
Sorry but I'm slightly against committing unused code or incomplete features. This would make sense to merge to me only once it's complete.
Owner
There was a problem hiding this comment.
Also - as we already support MCP, would be nice here to plug that in instead of including e.g. a scraper in the LocalAI code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses #5018 by updating the API schema. It adds support for the new web_search_options request parameter and the annotations response field.
This sets the stage for implementing "Deep Research" and web search features. It enables the API to process these fields according to the OpenAI specifications.
Notes for Reviewers
Added WebSearchOptions, UserLocation, and ApproximateLocation structs to pkg/schema/openai.go or core/schema/openai.go.
Added UrlCitation and Annotation structs to support search citations in responses.
Updated OpenAIRequest to include WebSearchOptions.
Updated Message struct to include Annotations.
This PR only updates the schema definitions; backend implementation logic will come in future PRs.Signed commits