Conversation
ie: ''' LOCALAI_IP_ALLOWLIST=192.168.1.0/24,10.0.0.1,127.0.0.1 '''
✅ Deploy Preview for localai ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
mudler
reviewed
Sep 11, 2025
core/http/utils/IPAllowList.go
Outdated
| @@ -0,0 +1,100 @@ | |||
| package utils | |||
Owner
There was a problem hiding this comment.
this looks better placed as ipallowlist.go file inside core/http rather than having it's own utils package.
mudler
reviewed
Sep 11, 2025
core/http/utils/IPAllowList_test.go
Outdated
| "testing" | ||
| ) | ||
|
|
||
| func TestIPAllowList(t *testing.T) { |
Owner
There was a problem hiding this comment.
better be consistent with all the other tests in this repository and use ginkgo
|
This PR is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ie:
'''
LOCALAI_IP_ALLOWLIST=192.168.1.0/24,10.0.0.1,127.0.0.1 '''
Description
This PR fixes #
Notes for Reviewers
Signed commits