fix on node 12/13 (hopefully) #7
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This fix seems to be working like a Charm. I'm using node 13.12.0 on OSX 10.15.5 |
|
I like it, it installs on Node 12+. However I cant seem to get this to work in an electron environment. It's complaining about addon.node could not locate the binding file. |
…ing node restriction
Adding Linux to Supported OS
|
I opened a pull request to solve the addon.node thing. Also it solved a build issue with node-gyp and msvs compiler flags on windows. I PRed it to this PR maybe I should just fork the main repo instead, but it used your Node12+ changes. |
ilimtvtr-alt
approved these changes
Dec 31, 2025
ilimtvtr-alt
approved these changes
Dec 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This seems to work on NodeJS 13, at least on macOS Catalina. This is my first time ever working with node-gyp so please excuse any glaring mistakes!