refactor: modernize meson build to use dependency() and override_dependency()#3
Open
mtao wants to merge 1 commit into
Open
refactor: modernize meson build to use dependency() and override_dependency()#3mtao wants to merge 1 commit into
mtao wants to merge 1 commit into
Conversation
…ndency()
Switch zipper consumption from subproject().get_variable() to
dependency() with [provide] section in wrap file. Add
meson.override_dependency() for art and art-headers so downstream
projects can consume them via dependency().
Remove dead code: unused dl_lib (cc.find_library('dl')) and unused
TBB_dep (dependency('tbb')) that were declared but never referenced.
Add viewer option to meson_options.txt for future balsa::visualization
integration.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
subproject().get_variable()todependency('zipper')with[provide]section in wrap filemeson.override_dependency('art', art_dep)andmeson.override_dependency('art-headers', art_headers_dep)so downstream projects can consume ART viadependency()dl_lib(cc.find_library('dl')) and unusedTBB_dep(dependency('tbb')) — both were declared but never added to any dependency listvieweroption tomeson_options.txtfor future balsa::visualization integrationPart of the cross-project meson modernization effort (zipper PR #12, cpp-template PR #1, quiver PR #7, balsa PR #6, archer PR #3).
Testing
1 test suite passes (145 assertions in 2 test cases). Build produces 17 targets successfully.
Note
PR #2 (
feature/image-and-io) adds EXR/PNG I/O with tinyexr and stb subprojects — those will need similar modernization (switch todependency()) when rebased on top of this.