Skip to content
This repository was archived by the owner on Aug 7, 2018. It is now read-only.

Fix cannot delete regions #80

Open
leonmak wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix cannot delete regions #80

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
732f487
Fix cannot delete regions
Mar 27, 2018
5082f1c
Update regions.js
leonmak Mar 27, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/plugins/regions.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,17 +58,14 @@ class Regions extends Component {
}

// cache reference to old regions
const oldRegions = Object.create(this.props.wavesurfer.regions.list);
const oldRegions = Object.assign({}, this.props.wavesurfer.regions.list);
let newRegionId;
let oldRegionId;

for (newRegionId in nextProps.regions) {
if ({}.hasOwnProperty.call(nextProps.regions, newRegionId)) {
const newRegion = nextProps.regions[newRegionId];

// remove from oldRegions
delete oldRegions[newRegionId];

// new regions
if (!this.props.wavesurfer.regions.list[newRegionId]) {
this._hookUpRegionEvents(nextProps.wavesurfer.addRegion(newRegion));
Expand All @@ -84,6 +81,9 @@ class Regions extends Component {
end: newRegion.end
});
}

// remove from oldRegions
delete oldRegions[newRegionId];
}
}

Expand Down