Add specific type hints to MCP tool functions#295
Open
ykd007 wants to merge 1 commit into
Open
Conversation
Use dict[str, Any] and list[dict[str, Any]] instead of plain dict/list for the MCP tool return types, and add a proper return type annotation to client.run(). Also imports typing.Any where needed so IDEs and mypy can reason about the shapes without losing flexibility.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #198
The MCP functions were using bare
dictandlistas return type annotations. This replaces them withdict[str, Any]andlist[dict[str, Any]]to give IDEs and static analysis tools (mypy/pyright) meaningful information about the shapes involved.Changes:
verify_llm,start_scan,stop_scan: return typedict→dict[str, Any]get_data_config,get_spec_templates: return typelist→list[dict[str, Any]]payloadvariable instart_scanannotated asdict[str, Any]client.run(): tightened from-> Noneto-> tuple[Any, Any, Any] | Noneto reflect the actual return value (prompts, resources, tools) or None on errorfrom typing import Anyto both files