Add type hints to MCP main.py local variables#293
Open
ykd007 wants to merge 1 commit into
Open
Conversation
The url and payload variables inside each tool function were untyped. Annotated them explicitly so IDEs and type checkers can follow the data flow without having to infer from context. Closes msoedov#198
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #198.
The
urlandpayloadlocal variables inside each tool function inagentic_security/mcp/main.pywere left without annotations. Added explicit: strand: dicthints so IDEs and static analysers (mypy, pyright) can track the types without having to infer them from the right-hand side.No behaviour change — strictly an annotation improvement.