Add logging to MCP main functions#292
Open
ykd007 wants to merge 1 commit into
Open
Conversation
Each tool now logs at debug level before making the HTTP request and at info level once the response status comes back. The __main__ block initialises basicConfig so the logs are visible when running the server directly. Closes msoedov#199
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Picked up from issue #199.
The five tool functions in
agentic_security/mcp/main.pyhad no logging at all, which made it hard to follow what was happening when running the MCP server in development or production.Added a module-level
logger = logging.getLogger(__name__)and two log calls per tool:logger.debugright before the HTTP request, showing the target URL and key parameterslogger.infoafter the response comes back, recording the HTTP status codeThe
__main__block now callslogging.basicConfig(level=logging.INFO)so the output is visible when the server is started directly withpython -m agentic_security.mcp.main.Closes #199