Implement PDF Editor tools according to existing approach#3
Open
msch-nutrient wants to merge 3 commits intomainfrom
Open
Implement PDF Editor tools according to existing approach#3msch-nutrient wants to merge 3 commits intomainfrom
msch-nutrient wants to merge 3 commits intomainfrom
Conversation
- Add duplicate_pages method for duplicating PDF pages or entire documents - Add delete_pages method for removing specific pages or page ranges - Add flatten method for flattening PDF form fields and annotations - Add rotate method for rotating PDFs by 90, 180, or 270 degrees - Add add_page method for inserting blank pages at various positions - Add set_page_label method for customizing page labels and numbering - Add json_import method for importing PSPDFKit instant JSON annotations - Add xfdf_import method for importing XFDF annotation data - Include comprehensive integration tests for all new methods - Add annotations.json fixture for JSON import testing All methods follow existing code patterns and support both file paths and File objects where applicable. Methods include proper error handling and parameter validation. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
- Remove all fixture skip conditions from PDF Editor tests - Fix JSON import temporary file handling by properly closing files - Update XFDF import to use annotations.xfdf fixture - All file-based imports now work correctly - Core PDF Editor functionality verified working 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
- Fix JSON import method to properly handle both Hash and String inputs - Update test to use actual working JSON content from annotations.json - Add proper JSON.dump handling for Hash inputs - All JSON and XFDF import tests now passing - Maintain backward compatibility for both file and inline data approaches 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implementation Details
Each method follows the existing code patterns established in the codebase:
build_parthelper pattern for file handlingTest Coverage
API Compliance
🤖 Generated with Claude Code