Fix MOSP: Use Zacks for growth estimates (closes #91).#92
Merged
mrhappyasthma merged 3 commits intomrhappyasthma:masterfrom Jan 23, 2025
Merged
Fix MOSP: Use Zacks for growth estimates (closes #91).#92mrhappyasthma merged 3 commits intomrhappyasthma:masterfrom
mrhappyasthma merged 3 commits intomrhappyasthma:masterfrom
Conversation
kocielnik
force-pushed
the
master
branch
2 times, most recently
from
8ae4c82 to
56dcb5e
Compare
kocielnik
commented
Nov 23, 2024
Contributor
Author
|
@mrhappyasthma, ready now, feel free to take a look:) |
kocielnik
added a commit
to kocielnik/IsThisStockGood
that referenced
this pull request
Dec 6, 2024
I expect the breaking of this test to be fixed by PR mrhappyasthma#92.
mrhappyasthma
pushed a commit
that referenced
this pull request
Dec 16, 2024
* Add 10Cap valuation (closes #88). * Delete the test that is not relevant anymore. I expect the breaking of this test to be fixed by PR #92. * Fix div id. * Make the test test the *API*, not NVDA:) Actually, the purpose of this commit is to bump the CI to run again, because it failed with an error that seems intermittent, and very rare. * Fix precision of 10Cap price. Before: ten_cap("NVDA") = 10.834 After: ten_cap("NVDA") = 10.83
kocielnik
commented
Dec 19, 2024
|
|
||
| data = json.loads(res.text) | ||
| assert data['debt_payoff_time'] == 0 | ||
| assert data['sticker_price'] > 0.0 |
Contributor
Author
There was a problem hiding this comment.
This line and the next one verify that each valuation method still works.
|
|
||
| def parse_json_data(self, data): | ||
| try: | ||
| print(data) |
Contributor
Author
There was a problem hiding this comment.
Yeah, that's unrelated to the issue:)
Contributor
Author
|
Resolved the conflicts. Feel free to take a look again, @mrhappyasthma! :) |
kocielnik
changed the title
Contributor
Author
|
Done:
@mrhappyasthma, please let me know if I can help in any other way:) |
Owner
|
I'll try to take a pass on this ASAP. Been busy with the holidays and such. |
Contributor
Author
|
Sure, thanks! |
In case it returns in the future (CR).
On no data from Yahoo Finance, use the estimate from Zacks.
Contributor
Author
|
Thanks for the comments, @mrhappyasthma! I believe I've applied all your suggestions. Please let me know what you think! |
Contributor
Author
|
The preview at https://isthisstockgood.vercel.app/ uses the updated code now. |
mrhappyasthma
approved these changes
Jan 23, 2025
Owner
|
Thanks again for all the help. Will deploy now |
Contributor
Author
|
You're welcome! Thank you for keeping this tool useful and maintainable! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I got very conservative estimates for the stocks I tried.
Probably this is still much better than nothing:)