Allow for custom growth rate in API and Web UI#101
Open
kocielnik wants to merge 1 commit intomrhappyasthma:masterfrom
Open
Allow for custom growth rate in API and Web UI#101kocielnik wants to merge 1 commit intomrhappyasthma:masterfrom
kocielnik wants to merge 1 commit intomrhappyasthma:masterfrom
Conversation
kocielnik
changed the title
kocielnik
changed the title
kocielnik
force-pushed
the
custom-growth-rate
branch
from
7f54132 to
8030d0a
Compare
kocielnik
commented
Oct 22, 2025
| placeholder="Ticker Symbol" | ||
| maxlength=8/> | ||
| </div> | ||
| <div class="col-md-2 nopadding"> |
Contributor
Author
There was a problem hiding this comment.
I found I couldn't submit the form while focus was on this field. It worked all right while focus was on the Ticker field, and on the "Analyze" button. @mrhappyasthma, any tips on how to fix that? :)
Contributor
Author
There was a problem hiding this comment.
I tried including \n in the RegEx in the script below. Didn't help.
kocielnik
force-pushed
the
custom-growth-rate
branch
from
952773f to
97d504b
Compare
Also: * Retry automatically twice on external API error. * Migrate project config from Poetry to UV. I've found UV to be more reliable, and generally faster than Poetry.
kocielnik
force-pushed
the
custom-growth-rate
branch
from
97d504b to
a9ac818
Compare
Contributor
Author
|
@mrhappyasthma LMKWYT:) |
Contributor
Author
|
Up-to-date preview: https://isthisstockgood.vercel.app/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fetching the growth rate has been failing once every few months.
Proposing to add an input box, for the user to provide their own growth rate percentage to be used in case fetching other values fails.
Q&A:
No, this issue is strictly about opening a way for the user to make the Sticker Price calculations work regardless of the failing API calls.
We can discuss this scenario in the future.
JavaScript will push back at you, disallowing explicit typing of non-numeric characters. If you force the form to accept your invalid input, the server will fail internally, because we cast whatever you provide to an
int.