-
Notifications
You must be signed in to change notification settings - Fork 34
Added Event Support #11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Any plans for this to get merged in? If it's waiting for a resolution of conflicts, I can provide a new PR with that included if that's needed. I'm going to be working off of my own fork with this, so just hoping this can get merged in at some point. |
|
(I've also updated things so that it does not do a console.log anywhere and events.tags can be used with a null events.options) |
|
@JamesMc86 thanks for great patch. I hesitated to keep this project alive because this is technically obsoleted since sivy/node-statsd get to support tag and histogram which were only differences b/w sivy/node-statsd and node-dogstatsd. But.. anyway :) |
|
Ah, I had no idea that node-statsd had added support for this. Which is amusing, because I use that library as well for some graphite work. I'm actually having trouble seeing this work. I should have that fixed up in the next day or two and will submit a new PR with that work in it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ups
|
See https://github.com/brightcove/hot-shots for a place where this has all been pulled in and is in use |
I require event support the library so this pull request includes the changes.