Skip to content

Conversation

@JamesWiresmith
Copy link

I require event support the library so this pull request includes the changes.

  • Added event function for generating events.
  • Refactored the tag generation into a single function that can be used by metrics and events.
  • Included testing for the above changes. (using mocha)

@bdeitte
Copy link

bdeitte commented Aug 4, 2015

Any plans for this to get merged in? If it's waiting for a resolution of conflicts, I can provide a new PR with that included if that's needed. I'm going to be working off of my own fork with this, so just hoping this can get merged in at some point.

@bdeitte
Copy link

bdeitte commented Aug 4, 2015

(I've also updated things so that it does not do a console.log anywhere and events.tags can be used with a null events.options)

@joybro
Copy link
Collaborator

joybro commented Aug 5, 2015

@JamesMc86 thanks for great patch.
@bdeitte would you please PR after resolving conflict?

I hesitated to keep this project alive because this is technically obsoleted since sivy/node-statsd get to support tag and histogram which were only differences b/w sivy/node-statsd and node-dogstatsd. But.. anyway :)

@bdeitte
Copy link

bdeitte commented Aug 5, 2015

Ah, I had no idea that node-statsd had added support for this. Which is amusing, because I use that library as well for some graphite work.

I'm actually having trouble seeing this work. I should have that fixed up in the next day or two and will submit a new PR with that work in it.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ups

@bdeitte
Copy link

bdeitte commented May 24, 2016

See https://github.com/brightcove/hot-shots for a place where this has all been pulled in and is in use

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants