player/screenshot: %tX template format fixes#17671
Open
na-na-hi wants to merge 4 commits intompv-player:masterfrom
Open
player/screenshot: %tX template format fixes#17671na-na-hi wants to merge 4 commits intompv-player:masterfrom
na-na-hi wants to merge 4 commits intompv-player:masterfrom
Conversation
localtime can fail and return NULL, which causes NULL dereference for strftime.
The format specifier is controlled by the user that can be arbitrary character. Using invalid specifier in strftime is UB. Fix this by only accepting the specifiers recognized in C11. Partial compatibility is provided for extension formats k, l, P by translating them to the closest standard alternative.
Previous commit left the common %s format extension unresolved. This implements the format in a platform independent way so it can be used on all platforms, including on Windows where strftime does not support %s.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes UB in some cases and allows %ts (unix timestamp) date format available on all platforms.