Skip to content

input/ipc-unix: don't delete file for abstract sockets#17665

Open
na-na-hi wants to merge 2 commits intompv-player:masterfrom
na-na-hi:absocket
Open

input/ipc-unix: don't delete file for abstract sockets#17665
na-na-hi wants to merge 2 commits intompv-player:masterfrom
na-na-hi:absocket

Conversation

@na-na-hi
Copy link
Copy Markdown
Contributor

If --input-ipc-server path name starts with "@", then "@" is replaced with a null character, which represents the abstract socket namespace on Linux. Because abstract sockets have no file system presence, it should not delete the file with the same name starting with "@".

Copy link
Copy Markdown
Member

@sfan5 sfan5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

If --input-ipc-server path name starts with "@", then "@" is replaced
with a null character, which represents the abstract socket namespace
on Linux. Because abstract sockets have no file system presence, it
should not delete the file with the same name starting with "@".
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants