ao/pulse: fix ao_drain hang when underrun makes buf_diff negative#17652
Open
dengzhongyuan365-dev wants to merge 1 commit intompv-player:masterfrom
Open
ao/pulse: fix ao_drain hang when underrun makes buf_diff negative#17652dengzhongyuan365-dev wants to merge 1 commit intompv-player:masterfrom
dengzhongyuan365-dev wants to merge 1 commit intompv-player:masterfrom
Conversation
dengzhongyuan365-dev
force-pushed
the
master
branch
from
bf0e808 to
13ff797
Compare
Dudemanguy
reviewed
Mar 30, 2026
Dudemanguy
reviewed
Mar 30, 2026
With prebuf=0, on underrun read_index overtakes write_index, making buf_diff negative. Passing it to pa_bytes_to_usec() (uint64_t) overflows and causes ao_drain() to hang forever via an infinite mp_cond_timedwait(). Fixes: 17651
dengzhongyuan365-dev
force-pushed
the
master
branch
from
13ff797 to
928d398
Compare
Author
|
@Dudemanguy |
Member
|
Do you have an easy way to reproduce this problem? |
Author
But，the code logic also presents computational problems. If an overflow occurs, it can cause subsequent stuttering, ultimately leading to the mpv freezing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With prebuf=0, on underrun read_index overtakes write_index, making
buf_diff negative. Passing it to pa_bytes_to_usec() (uint64_t) overflows
and causes ao_drain() to hang forever via an infinite mp_cond_timedwait().
Fixes: 17651