osc.lua: make box layout default to fluent icons#17620
Open
guidocella wants to merge 1 commit intompv-player:masterfrom
Open
osc.lua: make box layout default to fluent icons#17620guidocella wants to merge 1 commit intompv-player:masterfrom
guidocella wants to merge 1 commit intompv-player:masterfrom
Conversation
Following up to 88e741a, because box layout is also more rounded than bar layouts, default it to fluent icons.
kasper93
approved these changes
Mar 22, 2026
Member
kasper93
left a comment
kasper93
left a comment
There was a problem hiding this comment.
LGTM, thanks!
This is a change to current box layout, but I think new icons are good fit for it, they are both rounded.
Contributor
|
I consider this layout as a legacy, I personally hope it never changes. If it changed, would you consider to fix volume icon consistency? the size of speaker is not same between mute, low, normal, and high volume and does not keep on same position. |
Contributor
Author
|
Oh wow I see that, but it's a problem with the fluent volume icons in any layout. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following up to 88e741a, because box layout is also more rounded than bar layouts, default it to fluent icons.