demux_edl: support global_tags with delay_open#17609
Open
guidocella wants to merge 1 commit intompv-player:masterfrom
Open
demux_edl: support global_tags with delay_open#17609guidocella wants to merge 1 commit intompv-player:masterfrom
guidocella wants to merge 1 commit intompv-player:masterfrom
Conversation
The delay_open mechanism used by --script-opt=ytdl_hook-all_formats=yes breaks setting metadata with global_tags because tl->track_layout is NULL. See adcf51d cbb8f53 8ea7aa5. Fix this by applying tags to the EDL timeline in this case. Tags must still be applied to tl->track_layout when available for them to work with local EDL files.
guidocella
force-pushed
the
delay-open-tags
branch
from
ea857e7 to
93fe7a5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The delay_open mechanism used by
--script-opt=ytdl_hook-all_formats=yes breaks setting metadata with global_tags because tl->track_layout is NULL. See adcf51d cbb8f53 8ea7aa5.
Fix this by applying tags to the EDL timeline in this case.
Tags must still be applied to tl->track_layout when available for them to work with local EDL files.