select.lua: update the playlist submenu after playlist-move#17336
Merged
kasper93 merged 1 commit intompv-player:masterfrom Jan 28, 2026
Merged
select.lua: update the playlist submenu after playlist-move#17336kasper93 merged 1 commit intompv-player:masterfrom
kasper93 merged 1 commit intompv-player:masterfrom
Conversation
guidocella
force-pushed
the
playlist-move-fix
branch
2 times, most recently
from
e3f2299 to
7b36d8e
Compare
Contributor
Author
|
The only downside of this is that it updates |
kasper93
reviewed
Jan 26, 2026
guidocella
force-pushed
the
playlist-move-fix
branch
from
7b36d8e to
01edd7c
Compare
kasper93
reviewed
Jan 26, 2026
guidocella
force-pushed
the
playlist-move-fix
branch
from
01edd7c to
d65802d
Compare
kasper93
reviewed
Jan 28, 2026
guidocella
force-pushed
the
playlist-move-fix
branch
from
d65802d to
968ed67
Compare
kasper93
reviewed
Jan 28, 2026
Observing playlist-pos and playlist-count is not enough to update it
after playlist-move, but we can observe any playlist property with type
none to get notified of every MP_EVENT_CHANGE_PLAYLIST, even if the
property has not changed.
This is similar to the
mp.observe_property("vsync-jitter", "none", recorder) hack used by
stats.lua to replicate the deprecated tick event.
Fixes mpv-player#16816 (comment)
guidocella
force-pushed
the
playlist-move-fix
branch
from
968ed67 to
b283cab
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Observing playlist-pos and playlist-count is not enough to update it after playlist-move, but we can observe any playlist property with type none to get notified of every MP_EVENT_CHANGE_PLAYLIST, even if the property has not changed.
This is similar to the mp.observe_property("vsync-jitter", "none", recorder) hack used by stats.lua to replicate the deprecated tick event.
Fixes #16816 (comment)