Skip to content

video/out: use predefined pl_color_space_srgb#17326

Merged
kasper93 merged 1 commit intompv-player:masterfrom
kasper93:add_lum_to_opengl
Apr 17, 2026
Merged

video/out: use predefined pl_color_space_srgb#17326
kasper93 merged 1 commit intompv-player:masterfrom
kasper93:add_lum_to_opengl

Conversation

@kasper93
Copy link
Copy Markdown
Member

No description provided.

@kasper93
Copy link
Copy Markdown
Member Author

/cc @mahkoh @Lompik

Comment thread video/out/opengl/context_wayland.c Outdated
@mahkoh
Copy link
Copy Markdown
Contributor

mahkoh commented Jan 25, 2026

AIUI, vulkan mesa does not forward HDR metadata for SDR transfer functions. Therefore this should lead to the same behavior as far as wayland is concerned.

@kasper93
Copy link
Copy Markdown
Member Author

It has possibility to affect bt.1886 -> sRGB conversion, because bt.1886 is using luminance term. In either case, it's more cosmetic change, to show the same values in stats....

@kasper93 kasper93 force-pushed the add_lum_to_opengl branch 2 times, most recently from 4158e38 to 05d8aed Compare January 25, 2026 15:41
@kasper93
Copy link
Copy Markdown
Member Author

It also affects HDR->SDR conversion by adjusting BPC black level.

Also it makes --gpu-api=opengl output consistent with --gpu-api=vulkan --target-trc=srgb output. For this alone I think we should merge this.

@kasper93 kasper93 force-pushed the add_lum_to_opengl branch from 05d8aed to da20f03 Compare April 17, 2026 18:16
@kasper93 kasper93 changed the title opengl/context_wayland: use luminance information in sRGB mode video/out: use predefined pl_color_space_srgb Apr 17, 2026
@kasper93 kasper93 merged commit 6788174 into mpv-player:master Apr 17, 2026
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants