Enable HTTP/2 extended CONNECT from ProxyConfig#2
Draft
mpuncel wants to merge 1 commit into
Draft
Conversation
1712cc8 to
15a719e
Compare
15a719e to
1303aef
Compare
1303aef to
a178076
Compare
a178076 to
7722ac4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 Reworked this draft so HTTP/2 extended CONNECT is configured through the
ProxyConfigCRD instead of proxy environment metadata.Summary:
replace istio.io/api => github.com/mpuncel/api ....ProxyConfigenableHttp2Connect.networking.istio.io/v1beta1ProxyConfig.enableHttp2Connectinto effective meshProxyConfig.http2_protocol_options.allow_connecton sidecar outbound HTTP listeners when effective proxy config enables it.Validation:
go test ./pilot/pkg/networking/corego test ./pilot/pkg/modelgo test ./pkg/model -run 'TestNodeMetadata|TestStringBool'go test ./pilot/pkg/networking/core -run 'TestOutboundHTTP2ConnectProxyConfig|TestInboundHTTP2ConnectProxyConfig'go test ./pilot/pkg/model -run 'TestConvertToMeshConfigProxyConfig|TestEffectiveProxyConfig'git diff --checkNote: the temporary API
replaceshould become a normalistio.io/apipseudo-version bump after the fork API PR is merged into the target API branch.